Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depend on orocos_kdl_vendor #473

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Depend on orocos_kdl_vendor #473

merged 2 commits into from
Apr 4, 2022

Conversation

jacobperron
Copy link
Member

@jacobperron jacobperron commented Oct 28, 2021 •
edited
Loading

  • Change package.xml dependency to the vendor package
  • Add missing include directories for orocos_kdl
  • Install tf2_kdl as a header-only target

Connects to ros2/ros2#1208

@jacobperron jacobperron self-assigned this Oct 28, 2021
@jacobperron jacobperron mentioned this pull request Oct 28, 2021
Merged
@jacobperron jacobperron changed the title Fix linking against orocos-kdl Depend on orocos_kdl_vendor Feb 24, 2022
@jacobperron jacobperron marked this pull request as ready for review February 24, 2022 05:05
@jacobperron
Depend on orocos_kdl_vendor
ebedf3c 
* Change package.xml dependency to the vendor package
* Add missing include directories for orocos_kdl
  Upstream should probably be updated to use modern cmake targets.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Disable mem-access warnings on aarch64
8d79ded 
Same as #506, but in a different file
where Eigen headers are being included.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Member Author

I had to add 8d79ded to quiet compiler warnings coming from Eigen headers.

@jacobperron
Copy link
Member Author

@ros-pull-request-builder retest this please

@jacobperron jacobperron merged commit ea5b008 into ros2 Apr 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the jacob/upstream_orocos_kdl branch April 4, 2022 23:56
@ijnek ijnek mentioned this pull request Apr 5, 2022
Closed
@henningkayser henningkayser mentioned this pull request May 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz approved these changes

Assignees

@jacobperron jacobperron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jacobperron @sloretz