Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[foxy backport] Clear callbacks_to_remove variable after removing (#303) #314

Merged
merged 1 commit into from Aug 31, 2020
Merged

[foxy backport] Clear callbacks_to_remove variable after removing (#303) #314

merged 1 commit into from Aug 31, 2020

Conversation

mdtoom
Copy link
Contributor

@mdtoom mdtoom commented Aug 24, 2020

Backport #303 to Foxy.

@clalancette
Copy link
Contributor

Looks reasonable to me. I'll run CI on this next.

@clalancette
Copy link
Contributor

clalancette commented Aug 31, 2020 •
edited

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

While the builds are all red, they all successfully completed the build and colcon test-result returned a 0. The build is failing because of something to do with the pytest.ini xUnit Jenkins parsing. As I don't see any way that this PR caused the problem, I'm going to go ahead and merge it.

@clalancette clalancette merged commit 64d46d6 into ros2:foxy Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdtoom @clalancette