-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new substitution to read files #707
Comments
Confirmed that this also impacts my Iron source build on windows. |
The Python launch files read the contents of a URDF file directly using Python API, but the XML and YAML files call We could try to solve this by switching the - value: $(command 'cat $(find-pkg-share dummy_robot_bringup)/launch/single_rrbot.urdf')
+ value: $(eval 'open("$(find-pkg-share dummy_robot_bringup)/launch/single_rrbot.urdf", "r").read()') To be honest, I think the clean solution is to introduce a new substitution to read file contents in a portable way. The use case here (capturing a URDF for a |
I'll note that adding |
Wow nice find @cottsay! Do you think it's worth switching to |
In my opinion, we're too close to release to mess with a long-standing/low-impact bug like this, but I'm happy to open the PR if you think it warrants further discussion. |
I agree with @cottsay here that a new substitution to read file contents is the right way to go here. But given that this is a long-standing bug and a new feature request, I'm going to mark this for J-Turtle instead, move it to the |
As reported here osrf/ros2_test_cases#588 (comment)
The text was updated successfully, but these errors were encountered: