Allow ReadyToTest() usage in event handler #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikolai Morin <nikolai.morin@apex.ai>
nnmm
force-pushed
the
578-event-triggered-ready-to-test
branch
from
08b4a40
to
e571d7f
Compare
|
@clalancette Could you suggest a reviewer? |
|
Wow this looks really useful. I was just needing to do this (signal ReadyToTest once a test asset download has been complete). |
|
Thanks! @cottsay could you review this? |
|
methylDragon
approved these changes
Dec 2, 2022
|
Thank you for the contribution! 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #578.
The
LaunchDescriptionis searched for aReadyToTestaction recursively with thedescribe{_conditional}_sub_entities()functions ofLaunchDescriptionEntity. For aRegisterEventHandleraction, this calls thedescribe()function of the event handler, but the default implementation returns an empty list. So this PR overrides thedescribe()function for theOnActionEventBaseclass, which I think covers all the event handlers where you'd want to useReadyToTest:OnProcessExit,OnProcessIO,OnProcessStart,OnExecutionComplete.Apologies in advance for probably not using the right testing idioms, I'm not so familiar with the code base.