Pass the node-name attribute through the substitution parser #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanpauno
approved these changes
Dec 3, 2019
|
Thanks for the fix @mxgrey ! Sanity check:
|
ivanpauno
pushed a commit
that referenced
this pull request
Jan 17, 2020
ivanpauno
pushed a commit
that referenced
this pull request
Jan 17, 2020
Signed-off-by: ivan <ivanpauno@gmail.com>
ivanpauno
added a commit
that referenced
this pull request
Jan 21, 2020
* Add pid to launch_ros node name as suffix Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com> Signed-off-by: ivan <ivanpauno@gmail.com> * Pass the node-name attribute through the substitution parser (#101) Signed-off-by: ivan <ivanpauno@gmail.com> * Fix push-ros-namespace in xml/yaml launch files (#100) Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Signed-off-by: ivan <ivanpauno@gmail.com> * Maintain order of parameters regarding name and from (#99) Signed-off-by: Brian Ezequiel Marchi <brian.marchi65@gmail.com> Signed-off-by: ivan <ivanpauno@gmail.com> * Use imperative mood in constructor docstrings. (#103) * Use imperative mood in constructor docstrings. Fixes D401 in pycodestyle 5.0.0 and flake8. Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com> * Use imperative mood in docstring. Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com> * Use imperative mood in docstrings. Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com> Signed-off-by: ivan <ivanpauno@gmail.com> * Fix misleading deprecated warnings when using launch arguments (#106) Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Signed-off-by: ivan <ivanpauno@gmail.com> * check for shutdown while waiting for a service response to avoid hang during shutdown (#104) * check for shutdown while waiting for a service response to avoid hang during shutdown Signed-off-by: William Woodall <william@osrfoundation.org> * fix typo in logger call Signed-off-by: William Woodall <william@osrfoundation.org> Signed-off-by: ivan <ivanpauno@gmail.com> * Fix frontend topic remapping (#111) * Add frontend remap test Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Pass data_type parameter to remap entity This resolves an issue where frontend remaps are not parsed. Signed-off-by: Jacob Perron <jacob@openrobotics.org> Signed-off-by: ivan <ivanpauno@gmail.com> Co-authored-by: Brian Marchi <brian.marchi65@gmail.com> Co-authored-by: Grey <grey@openrobotics.org> Co-authored-by: Steven! Ragnarök <nuclearsandwich@users.noreply.github.com> Co-authored-by: William Woodall <william+github@osrfoundation.org> Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, it's not possible to use substitutions in the
node-nameattribute.