avoid deprecation warning, use from_parent #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
deleted the
dirk-thomas/avoid-deprecation-warning_from_parent
branch
This comment has been minimized.
This comment has been minimized.
dirk-thomas
restored the
dirk-thomas/avoid-deprecation-warning_from_parent
branch
dirk-thomas
force-pushed
the
dirk-thomas/avoid-deprecation-warning_from_parent
branch
from
55cfbda
to
537f340
Compare
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
force-pushed
the
dirk-thomas/avoid-deprecation-warning_from_parent
branch
from
537f340
to
a27e4dc
Compare
delete-merged-branch
bot
deleted the
dirk-thomas/avoid-deprecation-warning_from_parent
branch
sloretz
pushed a commit
that referenced
this pull request
Sep 8, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
sloretz
added a commit
that referenced
this pull request
Sep 8, 2020
… Call LaunchROSTestModule with the new API. (#150) (#176) * avoid deprecation warning, use from_parent (#141) Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Call LaunchROSTestModule with the new API. (#150) Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as ros2/launch#402.