Make name and namespace mandatory in ComposableNodeContainer, remove deprecated alternatives

[ivanpauno]

Based on discussion in #185, the name and namespace are mandatory.

I think that the intention was to check that, but it was overlooked when adding support for the deprecated name of the argument.
This delete the deprecated name (they were deprecated before Foxy release), and now it's checked.

[jacobperron]

This partially addresses #123.

[ivanpauno]

• Linux
• Linux-aarch64
• macOS
• Windows

[hidmic]

I'm not uber convinced we should be making name and namespace mandatory anywhere BUT we control this container executable so I guess it's fine.

LGTM pending green CI !

[clalancette]

One other thing to note; if we go forward with this, please add a note to https://index.ros.org/doc/ros2/Releases/Release-Galactic-Geochelone/ , since this is a change in behavior.

[ivanpauno]

One other thing to note; if we go forward with this, please add a note to https://index.ros.org/doc/ros2/Releases/Release-Galactic-Geochelone/ , since this is a change in behavior.

In Foxy, it was already mandatory both the name and the namespace.
The only difference is that the error wasn't handled correctly and rcl was showing an error (instead of launch detecting the error), but it was impossible to use the action correctly without passing both the name and namespace explicitly (and not None).

See eloquent code.

[jacobperron]

If anything, we should add a patch to Foxy to produce a better error message from the ComposableNodeContainer __init__.

[jacobperron]

See #191