Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[foxy] Improve error message if ComposableNodeContainer 'name' or 'namespace' arg is None #191

Merged
merged 3 commits into from
Oct 21, 2020
Merged

[foxy] Improve error message if ComposableNodeContainer 'name' or 'namespace' arg is None #191

merged 3 commits into from
Oct 21, 2020

Conversation

jacobperron
Copy link
Member

This restores the original behavior in Eloquent and Foxy, but with an improved error message.

The error was accidentally removed in #186.

@jacobperron
Add error message if ComposableNodeContainer 'namespace' arg is None
b9bb6d7 
This restores the original behavior in Eloquent and Foxy, but with an improved error message.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron self-assigned this Oct 21, 2020
@jacobperron jacobperron mentioned this pull request Oct 21, 2020
Merged
@jacobperron jacobperron changed the title Add error message if ComposableNodeContainer 'namespace' arg is None [foxy] Add error message if ComposableNodeContainer 'namespace' arg is None Oct 21, 2020
@jacobperron jacobperron added this to Proposed in Foxy Patch Release 4 via automation Oct 21, 2020
@jacobperron
Improve error message for no node name
7c11b83 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron changed the title [foxy] Add error message if ComposableNodeContainer 'namespace' arg is None [foxy] Add error message if ComposableNodeContainer 'name' or 'namespace' arg is None Oct 21, 2020
@jacobperron jacobperron changed the title [foxy] Add error message if ComposableNodeContainer 'name' or 'namespace' arg is None [foxy] Improve error message if ComposableNodeContainer 'name' or 'namespace' arg is None Oct 21, 2020
@jacobperron
Fix flake8
b85002d 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron merged commit 37bf199 into foxy Oct 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the jacob/improve_error_message branch October 21, 2020 22:20
@jacobperron jacobperron moved this from Proposed to Needs release in Foxy Patch Release 4 Oct 21, 2020
@jacobperron jacobperron moved this from Needs release to Released in Foxy Patch Release 4 Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

@clalancette clalancette clalancette approved these changes

@hidmic hidmic Awaiting requested review from hidmic

Assignees

@jacobperron jacobperron

Labels
None yet
Projects
No open projects
Foxy Patch Release 4
Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jacobperron @clalancette @ivanpauno