Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate complex attributes of 'node' action #198

Merged
merged 2 commits into from
Nov 4, 2020
Merged

Validate complex attributes of 'node' action #198

merged 2 commits into from
Nov 4, 2020

Conversation

ivanpauno
Copy link
Member

Related to ros2/launch#468.

@ivanpauno
Validate complex attributes of 'node' action
e3a97b2 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the enhancement New feature or request label Nov 2, 2020
@ivanpauno ivanpauno requested a review from hidmic November 2, 2020 21:30
@ivanpauno ivanpauno self-assigned this Nov 2, 2020
@ivanpauno ivanpauno mentioned this pull request Nov 2, 2020
Merged
@ivanpauno
fix
1b17bd7 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
hidmic
hidmic approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI

@ivanpauno ivanpauno merged commit 2d3b021 into master Nov 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/validate-unparsed-attributes branch November 4, 2020 12:52
@ivanpauno ivanpauno mentioned this pull request Nov 9, 2020
Closed
@adityapande-1995 adityapande-1995 mentioned this pull request Dec 8, 2021
Open
@adityapande-1995
Copy link
Contributor

@Mergifyio backport foxy

mergify bot pushed a commit that referenced this pull request Dec 8, 2021
@ivanpauno
Validate complex attributes of 'node' action (#198)
7a43463 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
(cherry picked from commit 2d3b021)

# Conflicts:
#	launch_ros/launch_ros/actions/node.py
@mergify mergify bot mentioned this pull request Dec 8, 2021
Merged
@mergify
Copy link

mergify bot commented Dec 8, 2021

backport foxy

✅ Backports have been created

adityapande-1995 added a commit that referenced this pull request Jan 14, 2022
@mergify @ivanpauno @adityapande-1995
Validate complex attributes of 'node' action (backport #198) (#293)
d2c726b 
* Validate complex attributes of 'node' action (#198)

Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Co-authored-by: Aditya Pande <aditya050995@gmail.com>
jacobperron added a commit that referenced this pull request Feb 22, 2022
@jacobperron
Revert "Validate complex attributes of 'node' action (backport #198) (#…
25228a0 
…293)"

This reverts commit d2c726b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

Assignees

@ivanpauno ivanpauno

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivanpauno @adityapande-1995 @hidmic