-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate complex attributes of 'node' action (backport #198) #293
Conversation
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> (cherry picked from commit 2d3b021) # Conflicts: # launch_ros/launch_ros/actions/node.py
Signed-off-by: Aditya <aditya050995@gmail.com>
8da3d7f
to
656ec8f
Compare
CI throws error : |
Backport PR has already been merged ros2/launch#567, we only need to do a foxy release for the Fpr checker to pass. |
@ros-pull-request-builder retest this please |
There are a lot of foxy packages still being built after ros/rosdistro#31744 got merged: https://build.ros2.org/view/Queue/. The testing repo will be synced after all Fbin* jobs finish, we need to rerun the pull request builder after that. |
@ros-pull-request-builder retest this please |
CI : The |
This is an automatic backport of pull request #198 done by Mergify.
Cherry-pick of 2d3b021 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com