Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate complex attributes of 'node' action (backport #198) #293

Merged
merged 2 commits into from
Jan 14, 2022

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Dec 8, 2021

This is an automatic backport of pull request #198 done by Mergify.
Cherry-pick of 2d3b021 has failed:

On branch mergify/bp/foxy/pr-198
Your branch is up to date with 'origin/foxy'.

You are currently cherry-picking commit 2d3b021.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   launch_ros/launch_ros/actions/node.py

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
(cherry picked from commit 2d3b021)

# Conflicts:
#	launch_ros/launch_ros/actions/node.py
Signed-off-by: Aditya <aditya050995@gmail.com>
@adityapande-1995
Copy link
Contributor

CI throws error : AttributeError: 'Entity' object has no attribute 'assert_entity_completely_parsed'. Probably need to backport ros2/launch#468. What do you think @ivanpauno ?

@ivanpauno
Copy link
Member

Backport PR has already been merged ros2/launch#567, we only need to do a foxy release for the Fpr checker to pass.

@adityapande-1995
Copy link
Contributor

@ros-pull-request-builder retest this please

@ivanpauno
Copy link
Member

There are a lot of foxy packages still being built after ros/rosdistro#31744 got merged: https://build.ros2.org/view/Queue/.

The testing repo will be synced after all Fbin* jobs finish, we need to rerun the pull request builder after that.

@adityapande-1995
Copy link
Contributor

@ros-pull-request-builder retest this please

@adityapande-1995
Copy link
Contributor

adityapande-1995 commented Jan 14, 2022

CI :

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

The test_qos_profiles error seems unrelated and was also seen here in a vanilla foxy CI : #289 (comment) . It is a known issue and is ticketed here is : ros2/rosbag2#927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants