Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FindPackage substitution #22

Merged
merged 6 commits into from
May 21, 2019
Merged

Add FindPackage substitution #22

merged 6 commits into from
May 21, 2019

Conversation

ivanpauno
Copy link
Member

A convenient substitution for finding a package.
Nice to have for launch_frontend work.

@ivanpauno ivanpauno added enhancement New feature or request in review labels May 9, 2019
@ivanpauno ivanpauno requested a review from hidmic May 9, 2019 13:28
@ivanpauno ivanpauno self-assigned this May 9, 2019
hidmic
hidmic requested changes May 15, 2019
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW do we have at least an indirect test of the functionality?

launch_ros/launch_ros/substitutions/find_package.py Outdated Show resolved Hide resolved
launch_ros/launch_ros/substitutions/find_package.py Outdated Show resolved Hide resolved
launch_ros/launch_ros/substitutions/find_package.py Show resolved Hide resolved
@ivanpauno ivanpauno requested a review from hidmic May 17, 2019 18:54
@ivanpauno
Copy link
Member Author

CI (build: --packages-up-to test_launch_ros, test: --packages-select launch_ros test_launch_ros, only fastrtps)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno
Copy link
Member Author

Again windows CI:

  • Windows Build Status

@ivanpauno
Add FindPackage substitution
6856f4f 
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno
Corrected doc strings
8046e4d 
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno
Corrected with PR comments.
204e1b0 
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno
Corrected FindPackage test on windows
ba2ac4f 
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno
Simplfy test
6754f8f 
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno force-pushed the ivanpauno/find-package-substitution branch from 0e33e55 to 6754f8f Compare May 20, 2019 13:55
@ivanpauno
Copy link
Member Author

ivanpauno commented May 20, 2019 •
edited
Loading

My test relied in that we weren't used merge install option. CI again with simpler test:

  • Windows Build Status

hidmic
hidmic approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI

launch_ros/launch_ros/substitutions/find_package.py Show resolved Hide resolved
@hidmic
Copy link
Contributor

hidmic commented May 20, 2019

My test relied in that we weren't used merge install option.

Hmm it'd be nice to at least use that package prefix to locate something that should be there. Otherwise, we are not testing anything.

@ivanpauno
Better testing
0208f44 
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno
Copy link
Member Author

My test relied in that we weren't used merge install option.

Hmm it'd be nice to at least use that package prefix to locate something that should be there. Otherwise, we are not testing anything.

It was only testing that ament_index_python.packages.get_package_prefix found the package and didn't raise an exception. I pushed a better test in 0208f44.

@ivanpauno
Copy link
Member Author

CI (build: --packages-up-to test_launch_ros, test: --packages-select launch_ros test_launch_ros, only fastrtps)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno requested a review from hidmic May 20, 2019 16:04
hidmic
hidmic approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again!

@ivanpauno ivanpauno merged commit 2d5d3ea into master May 21, 2019
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/find-package-substitution branch May 21, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

Assignees

@ivanpauno ivanpauno

Labels
enhancement New feature or request in review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanpauno @hidmic