-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LaunchConfiguration is not read from ComposableNode when included inside a group action #328
Comments
So we do have tests to ensure that
So I'm somewhat confident the basic functionality works. That said, we don't have tests for |
Well..., two things: The LaunchConfigurationEquals and LaunchConfigurationNotEquals conditions are pretty recently deprecated. Also, weird things happen when trying to check for equality with empty strings with that condition.. Try with the EqualsSubstitution instead! e.g.:
If that fails, try the more terse conditions as suggested by Chris, above. |
How do i upgrade the launch package to have this changes, it seems that this feature was added not recently. I am using ros2 rolling. @methylDragon |
Try
|
I get this when I try to upgrade, is this feature available in ros-rolling yet?
|
Hmm, you're right. The update was released 5 days ago, but it might take a little while for it to get through to the main repos. It should come out soon though. |
I am facing the similar issue, but I am using IfCondition. You may find the issue description here: |
I think the issue is related. I am going to put some time into investigating this... |
Hello! This PR should address the issue (: Do note that it'll take a little while for this change to propagate through and get released (the PR will need to get merged, then the repo has to get released, and finally there has to be a rolling sync.) So I'd recommend building from source if you want the change immediately. |
Thanks for the update |
Changes being made now in Nav2 https://github.com/ros-planning/navigation2/pull/3445/files I'll say that having to replace |
Bug report
Required Info:
Steps to reproduce issue
Expected behavior
It should pay attention to the condition but executes both composable node. The issue #114 should have fixed it but seems not to have.
Actual behavior
It does not pay attention to the condition at all and executes both composablenode
Additional information
Feature request
Feature description
Implementation considerations
The text was updated successfully, but these errors were encountered: