Allow separate launch composition

[oceanusxiv]

As mentioned in #75, this is my attempt to allow composing nodes in different launch files. This change allows this by making target_container also a substitution so users can pass in the container node name. That way the container node itself can be executed first in another launch file.

[oceanusxiv]

@ivanpauno so is this good?

[ivanpauno]

@ivanpauno so is this good?

Yes, it's good.
We can follow-up about is_a_subclass usage later (#77 (comment)).

---

We're currently in a feature freeze, so this is not going to be merged into master until we create an Eloquent branch (probably in one/two weeks).

[oceanusxiv]

@ivanpauno gentle ping now that the feature freeze seems to be over.

[ivanpauno]

Thanks for the reminder @eric1221bday

CI (using rebased branch ivanpauno/test-#77):

• Linux
• Linux-aarch64

[ivanpauno]

nit: delete unnecessary change.

[ivanpauno]

@eric1221bday please address flake8 failures.

[oceanusxiv]

@ivanpauno should be fixed

[ivanpauno]

Sanity check (using rebased branch ivanpauno/test-#77):

• Linux
• Linux-aarch64
• MacOS
• Windows

[ivanpauno]

Going in! Thanks for the contribution @eric1221bday !

[jacobperron]

I'd like to see this change backported to Eloquent.

Since it looks like mainly bug fixes since the last release, maybe we can sync the eloquent branch with master?

[ivanpauno]

Since it looks like mainly bug fixes since the last release, maybe we can sync the eloquent branch with master?

Sounds reasonable to me.