Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[foxy] Improve error message if ComposableNodeContainer 'name' or 'namespace' arg is None #191

Merged
merged 3 commits into from
Oct 21, 2020
Merged

[foxy] Improve error message if ComposableNodeContainer 'name' or 'namespace' arg is None #191

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9bb6d7
Add error message if ComposableNodeContainer 'namespace' arg is None
jacobperron Oct 21, 2020
7c11b83
Improve error message for no node name
jacobperron Oct 21, 2020
b85002d
Fix flake8
jacobperron Oct 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion launch_ros/launch_ros/actions/composable_node_container.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,10 @@ def __init__(
)
namespace = node_namespace

if not namespace:
if namespace is None:
raise RuntimeError("'namespace' is a required argument")
jacobperron marked this conversation as resolved.
Show resolved Hide resolved

if namespace == '':
ivanpauno marked this conversation as resolved.
Show resolved Hide resolved
namespace = '/'
super().__init__(name=name, namespace=namespace, **kwargs)
self.__composable_node_descriptions = composable_node_descriptions
Expand Down