Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code, Future.result() already raises #270

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Remove unused code, Future.result() already raises #270

merged 1 commit into from
Sep 23, 2021

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Sep 23, 2021

This removes some unused code. rclpy.task.Future.result() already raises if there's an exception.

https://github.com/ros2/rclpy/blob/691e4fbfcb4bd4cc2a01182a7dced3105a78200b/rclpy/rclpy/task.py#L93-L94

@sloretz
Remove unused code, Future.result() already raises
0d0f9d4 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz self-assigned this Sep 23, 2021
@adityapande-1995 adityapande-1995 mentioned this pull request Sep 23, 2021
Merged
@sloretz
Copy link
Contributor Author

sloretz commented Sep 23, 2021

CI (build: --packages-up-to launch_testing_ros test: --packages-select launch_testing_ros)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz merged commit 999b208 into master Sep 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the future_already_raises branch September 23, 2021 21:46
@sloretz sloretz mentioned this pull request Oct 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityapande-1995 adityapande-1995 adityapande-1995 approved these changes

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sloretz @adityapande-1995