Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load composable nodes in sequence (backport #315) #316

Merged
merged 1 commit into from Apr 28, 2022

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Apr 26, 2022

This is an automatic backport of pull request #315 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Load composable nodes in sequence

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Undo whitespace change

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
(cherry picked from commit 7fa69bc)
@sloretz sloretz requested a review from audrow April 26, 2022 17:13
@sloretz
Copy link
Contributor

sloretz commented Apr 26, 2022

CI (Humbles repos file, build: --packages-up-to test_launch_ros test: --packages-select test_launch_ros)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Copy link
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI.

@sloretz
Copy link
Contributor

sloretz commented Apr 28, 2022

CI LGTM

The two test failures are in a different test file that doesn't use the test this file changes. I think they're both flaky tests.

One of the test failures also happened in a nightly job: https://ci.ros2.org/view/nightly/job/nightly_win_rep/2597/#showFailuresLink

@sloretz sloretz merged commit b49996c into humble Apr 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/humble/pr-315 branch April 28, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants