Skip to content

Commit

Permalink
Load composable nodes in sequence (#315) (#316)
Browse files Browse the repository at this point in the history
* Load composable nodes in sequence

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Undo whitespace change

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
(cherry picked from commit 7fa69bc)

Co-authored-by: Shane Loretz <sloretz@osrfoundation.org>
  • Loading branch information
mergify[bot] and sloretz committed Apr 28, 2022
1 parent d3970e5 commit b49996c
Showing 1 changed file with 22 additions and 17 deletions.
Expand Up @@ -329,23 +329,28 @@ def test_load_node_with_param_file(mock_component_container):

# Case 6: multiple entries (params with node name should take precedence over wildcard params)
context = _assert_launch_no_errors([
_load_composable_node(
package='foo_package',
plugin='bar_plugin',
name='node_1',
namespace='ns_1',
parameters=[
parameters_file_dir / 'example_parameters_multiple_entries.yaml'
],
),
_load_composable_node(
package='foo_package',
plugin='bar_plugin',
name='node_2',
namespace='ns_2',
parameters=[
parameters_file_dir / 'example_parameters_multiple_entries.yaml'
],
LoadComposableNodes( # Load in same action so it happens sequentially
target_container=f'/{TEST_CONTAINER_NAME}',
composable_node_descriptions=[
ComposableNode(
package='foo_package',
plugin='bar_plugin',
name='node_1',
namespace='ns_1',
parameters=[
parameters_file_dir / 'example_parameters_multiple_entries.yaml'
]
),
ComposableNode(
package='foo_package',
plugin='bar_plugin',
name='node_2',
namespace='ns_2',
parameters=[
parameters_file_dir / 'example_parameters_multiple_entries.yaml'
]
)
]
)
])
request = mock_component_container.requests[-2]
Expand Down

0 comments on commit b49996c

Please sign in to comment.