Suppress update of pinned git repository #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The source at that ref will never change, so there is no need to try to update it. This will avoid unnecessary invalidation of the build and install targets for the external project. Signed-off-by: Scott K Logan <logans@cottsay.net>
clalancette
approved these changes
Feb 1, 2021
There was a problem hiding this comment.
The change looks good to me, but I'd feel better with a more comprehensive CI since mimick tends to be finicky. In particular, I'd suggest running tests --packages-above mimick_vendor, and also running CI against Windows Debug and CentOS jobs in addition to the normal jobs.
|
Since mimick is used in rcutils, that will blow out to nearly an entire rebuild. I can do it, but it will be a while. Wider builds with Debug:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source at that ref will never change, so there is no need to try to update it. This will avoid unnecessary invalidation of the build and install targets for the external project.
This is the same issue we're working around in ament/uncrustify_vendor#22.