New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmarks to evaluate overhead #11
Conversation
Signed-off-by: Stephen Brawner <brawner@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments. Also, please re-run CI with AMENT_RUN_PERFORMANCE_TESTS=1
to see what the results are like.
Benchmark results can be seen here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good once BENCHMARK_MAIN
has been dropped.
This is great. I'd like to note, however, that the You'd have to use a separate test and add it with |
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Without memory tools. I'm impressed by the memory latency of this build on cloud VMs.
|
Signed-off-by: Stephen Brawner <brawner@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of thoughts on the new stuff.
Signed-off-by: Stephen Brawner <brawner@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably get one last round of CI, but this looks good to me. Thanks for iterating.
Warnings on aarch and windows are just the expected ones for benchmarks. |
Based on some feedback from #10 I wanted to measure overhead of different choices with this infrastructure. This adds malloc/realloc benchmarks to measure the overhead of tracking them. It also enables linters for this package.
Signed-off-by: Stephen Brawner brawner@gmail.com