Skip to content

Commit

Permalink
add unit tests for --log-file-name argument. (#1130)
Browse files Browse the repository at this point in the history
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
  • Loading branch information
fujitatomoya committed Jan 8, 2024
1 parent f8af11f commit 750fc16
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion rcl/test/rcl/test_arguments.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,12 @@ TEST_F(TestArgumentsFixture, check_known_vs_unknown_args) {
EXPECT_FALSE(are_known_ros_args({"--ros-args", "--log", "foo"}));
EXPECT_FALSE(are_known_ros_args({"--ros-args", "--loglevel", "foo"}));

// Setting log file name prefix
EXPECT_TRUE(are_known_ros_args({"--ros-args", "--log-file-name", "filename"}));

EXPECT_FALSE(are_known_ros_args({"--ros-args", "--logfile-name", "filename"}));
EXPECT_FALSE(are_known_ros_args({"--ros-args", "--log-filename", "filename"}));

// Disabling logging
EXPECT_TRUE(are_known_ros_args({"--ros-args", "--enable-rosout-logs"}));
EXPECT_TRUE(are_known_ros_args({"--ros-args", "--disable-rosout-logs"}));
Expand Down Expand Up @@ -220,7 +226,7 @@ TEST_F(TestArgumentsFixture, check_valid_vs_invalid_args) {
{
"--ros-args", "-p", "foo:=bar", "-r", "__node:=node_name",
"--params-file", parameters_filepath.c_str(), "--log-level", "INFO",
"--log-config-file", "file.config"
"--log-config-file", "file.config", "--log-file-name", "filename"
}));

// ROS args unknown to rcl are not (necessarily) invalid
Expand Down Expand Up @@ -283,6 +289,8 @@ TEST_F(TestArgumentsFixture, check_valid_vs_invalid_args) {

EXPECT_FALSE(are_valid_ros_args({"--ros-args", "--log-level"}));
EXPECT_FALSE(are_valid_ros_args({"--ros-args", "--log-level", "foo"}));

EXPECT_FALSE(are_valid_ros_args({"--ros-args", "--log-file-name"}));
}

TEST_F(TestArgumentsFixture, test_no_args) {
Expand Down

0 comments on commit 750fc16

Please sign in to comment.