Skip to content

Commit

Permalink
Log warning when remapping to an invalid node name (#454)
Browse files Browse the repository at this point in the history
Similar to the warnings when remapping to invalid namespaces, this better communicates failures to the user.

Resolves #449

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
  • Loading branch information
jacobperron committed Jun 5, 2019
1 parent 8085c6a commit 79b3ec1
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions rcl/src/rcl/arguments.c
Original file line number Diff line number Diff line change
Expand Up @@ -978,6 +978,9 @@ _rcl_parse_remap_nodename_replacement(
// new_node_name
ret = rcl_lexer_lookahead2_expect(lex_lookahead, RCL_LEXEME_TOKEN, &node_name, &length);
if (RCL_RET_WRONG_LEXEME == ret) {
node_name = rcl_lexer_lookahead2_get_text(lex_lookahead);
RCUTILS_LOG_WARN_NAMED(
ROS_PACKAGE_NAME, "Node name not remapped to invalid name: '%s'", node_name);
return RCL_RET_INVALID_REMAP_RULE;
}
if (RCL_RET_OK != ret) {
Expand Down

0 comments on commit 79b3ec1

Please sign in to comment.