Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use user-defined allocator to configure logging. #1047

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

fujitatomoya
Copy link
Collaborator

address #1036

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Copy link
Collaborator

@iuhilnehc-ynos iuhilnehc-ynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on rcl layer, there are two exported functions to set allocator for rcutils log module.

  1. rcl_logging_configure -> rcl_logging_configure_with_output_handler
  2. rcl_logging_configure_with_output_handler

If a component(such as rclcpp) doesn't call the above functions, logging functions on rcutils layer use the default allocator by the RCUTILS_LOGGING_AUTOINIT.

I think it makes sense.

@iuhilnehc-ynos
Copy link
Collaborator

and we need to remove

rcl/rcl/src/rcl/init.c

Lines 71 to 74 in cae279a

RCUTILS_LOG_DEBUG_NAMED(
ROS_PACKAGE_NAME,
"Initializing ROS client library, for context at address: %p", (void *) context);
.

@fujitatomoya
Copy link
Collaborator Author

and we need to remove

rcl/rcl/src/rcl/init.c

Lines 71 to 74 in cae279a

RCUTILS_LOG_DEBUG_NAMED(
ROS_PACKAGE_NAME,
"Initializing ROS client library, for context at address: %p", (void *) context);

.

this one has been already pointed out by #1037, i believe that each PR should be against specific issue. So i will not address it here.

@fujitatomoya
Copy link
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

https://ci.ros2.org/job/ci_windows/18945/#showFailuresLink unstable failure is not related to this PR.

@fujitatomoya fujitatomoya merged commit ca07900 into rolling Mar 21, 2023
@delete-merged-branch delete-merged-branch bot deleted the fujitatomoya/bugfix-rcl-issues-1036 branch March 21, 2023 21:17
danthony06 pushed a commit to danthony06/rcl that referenced this pull request Jun 14, 2023
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants