Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish for rosout topic multiple times to avoid flaky test #1054

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

iuhilnehc-ynos
Copy link
Collaborator

to fix #1050

Sorry, I updated the publish times to once in #921 as I thought the publisher using qos(

RMW_QOS_POLICY_RELIABILITY_RELIABLE,
RMW_QOS_POLICY_DURABILITY_TRANSIENT_LOCAL,
) can make the subscribe using qos(https://github.com/ros2/rmw/blob/ac633c09056fb8525c072513c4a2665e7c13a530/rmw/include/rmw/qos_profiles.h#L55-L56) receive the message.

Signed-off-by: Chen Lihui <lihui.chen@sony.com>
@iuhilnehc-ynos
Copy link
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya self-requested a review April 5, 2023 07:27
@fujitatomoya fujitatomoya self-assigned this Apr 5, 2023
@fujitatomoya
Copy link
Collaborator

@clalancette @Crola1702 friendly ping.

@clalancette clalancette merged commit 06a21c8 into ros2:rolling Apr 5, 2023
@clalancette clalancette added this to In progress in Iron Irwini via automation Apr 5, 2023
@clalancette clalancette moved this from In progress to Done in Iron Irwini Apr 6, 2023
danthony06 pushed a commit to danthony06/rcl that referenced this pull request Jun 14, 2023
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Flaky test on Windows on the buildfarm: test_logging_rosout__rmw_connextdds
3 participants