fix flaky test #1063
Merged
fix flaky test #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
iuhilnehc-ynos
requested review from
audrow,
ivanpauno and
wjwwood
as code owners
|
CI:
|
Co-authored-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
This reverts commit a1f3c0d. Signed-off-by: Chen Lihui <lihui.chen@sony.com>
This reverts commit 1c83504. Signed-off-by: Chen Lihui <lihui.chen@sony.com>
clalancette
approved these changes
Apr 17, 2023
|
|
OK, this one looks good to me. @fujitatomoya can you take another look, and if you agree approve and merge this one? Thanks. |
fujitatomoya
approved these changes
Apr 17, 2023
|
@clalancette thanks! |
danthony06
pushed a commit
to danthony06/rcl
that referenced
this pull request
Jun 14, 2023
* fix flaky test Signed-off-by: Chen Lihui <lihui.chen@sony.com> * avoid RCL_RET_NODE_NAME_NON_EXISTENT case instead of removing ASSERT Co-authored-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> * return immediately Signed-off-by: Chen Lihui <lihui.chen@sony.com> * set the out parameter Signed-off-by: Chen Lihui <lihui.chen@sony.com> * Revert "set the out parameter" This reverts commit a1f3c0d. Signed-off-by: Chen Lihui <lihui.chen@sony.com> * Revert "return immediately" This reverts commit 1c83504. Signed-off-by: Chen Lihui <lihui.chen@sony.com> --------- Signed-off-by: Chen Lihui <lihui.chen@sony.com> Co-authored-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix #1062
rcl/rcl/test/rcl/test_graph.cpp
Line 870 in 959ef28
is only called in VerifySubsystemCount, which expect to cost (20*400ms) if failure happened in the test,
but we can find
[ FAILED ] NodeGraphMultiNodeFixture.test_node_info_publishers (3909 ms)just consume 4s running the test.I think this ASSERT can be removed as the discovery in operations (1, 2, 3, 4) might be asynchronous(doc needs to be updated) which is similar to rmw_get_publishers_info_by_topic.
rcl_get_publisher_names_and_types_by_node->rmw_get_publisher_names_and_types_by_node->rmw_api_connextdds_get_publisher_names_and_types_by_node-> ... ->get_writer_names_and_types_by_node->GraphCache::get_writer_names_and_types_by_node->https://github.com/ros2/rmw_dds_common/blob/0dc8af3cc1c471c60a96e896ab66633d486feb50/rmw_dds_common/src/graph_cache.cpp#L891-L898