Fix a clang warning for suspicious string concatentation. #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang warns when strings are concatenated within array declarations; this can help to catch bugs. However, in the cases here we actually mean to do string concatenation. Signal this to the compiler by making a separate variable where we do the concatenation, which quiets the clang warning and should have no effect on operation. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
requested review from
audrow,
ivanpauno and
wjwwood
as code owners
|
CI:
|
mjcarroll
approved these changes
Sep 11, 2023
fujitatomoya
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang warns when strings are concatenated within array declarations; this can help to catch bugs.
However, in the cases here we actually mean to do string concatenation. Signal this to the compiler by making a separate variable where we do the concatenation, which quiets the clang warning and should have no effect on operation.