Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed warnings - strict-prototypes #1148

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Fixed warnings - strict-prototypes #1148

merged 2 commits into from
Apr 23, 2024

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Apr 17, 2024

There are new warnings on CI related with this compiler option strict-prototypes

https://ci.ros2.org/view/nightly/job/nightly_linux_clang_libcxx/1860/gcc/new/

@ahcorde
Fixed warnings - strict-prototypes
3dd2106 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Apr 17, 2024
@ahcorde
more warnings
b3c65cc 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
clalancette
clalancette approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI.

Let's put this on the queue to merge after the freeze is lifted.

@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 23, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 7af6d3a into rolling Apr 23, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/rolling/warnings branch April 23, 2024 16:31
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 23, 2024

https://github.com/Mergifyio backport jazzy

@mergify Mergify
Copy link

mergify bot commented Apr 23, 2024 •
edited
Loading

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 23, 2024
@ahcorde @mergify
Fixed warnings - strict-prototypes (#1148)
bff6c57 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 7af6d3a)
@mergify mergify bot mentioned this pull request Apr 23, 2024
Merged
ahcorde added a commit that referenced this pull request Apr 24, 2024
@mergify @ahcorde
Fixed warnings - strict-prototypes (#1148) (#1150)
555b64f 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 7af6d3a)

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

@ivanpauno ivanpauno Awaiting requested review from ivanpauno ivanpauno is a code owner

@wjwwood wjwwood Awaiting requested review from wjwwood wjwwood is a code owner

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahcorde @clalancette @fujitatomoya