Fix up rmw_cyclonedds timestamp testing. (backport #1156) #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
We are about to fix it so that rmw_cyclonedds has receive_timestamp support, so we also need to enable that support here in rcl. We actually rewrite the logic a bit because now the only combination that doesn't work is rmw_connextdds on Windows. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 6d53d24)
marcoag
approved these changes
May 9, 2024
MichaelOrlov
approved these changes
May 10, 2024
|
CI for this is over in ros2/rmw_cyclonedds#493 (comment). With that, and 2 reviews, going ahead and merging this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are about to fix it so that rmw_cyclonedds has receive_timestamp support, so we also need to enable that support here in rcl. We actually rewrite the logic a bit because now the only combination that doesn't work is rmw_connextdds on Windows.
This is the counterpart to ros2/rmw_cyclonedds#491 , and must be merged at the same time.
This is an automatic backport of pull request #1156 done by Mergify.