free valid_transitions for all states #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
transition_map->states[i].valid_transitions wasn't being release which was leaking about 800 bytes per instantiation. See aliasrobotics/RVD#333 Signed-off-by: Víctor Mayoral Vilches <v.mayoralv@gmail.com>
|
@clalancette, @dirk-thomas ping in here. |
|
Thanks. I'll re-kick linux CI to see if the regression is still there: CI: * Linux |
|
All right, looking good. I'll run a slightly more complete CI across all of the platforms; assuming that comes back clean, I'm happy with this.
|
clalancette
approved these changes
Nov 22, 2019
|
All right, I'm happy with this now. Thanks @vmayoral ! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows from #509