Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rcl_x_is_valid methods #81

Closed
firesurfer opened this issue Sep 23, 2016 · 7 comments
Closed

Implement rcl_x_is_valid methods #81

firesurfer opened this issue Sep 23, 2016 · 7 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@firesurfer
Copy link
Contributor

In order to track what was discussed in #78 I open this issue tracker.

@wjwwood suggested that in the future it might become necessary/useful to implement functions in the style rcl_x_is_valid .

An example would be: bool rcl_service_is_valid(rcl_service_t * service) which would check if this service is valid. (Perhaps check if it's not null, check if it was initialized, and so on)

@wjwwood wjwwood added enhancement New feature or request help wanted Extra attention is needed labels Sep 23, 2016
@wjwwood
Copy link
Member

wjwwood commented Sep 23, 2016

Thanks!

@allenh1
Copy link
Contributor

allenh1 commented Dec 23, 2016

@tfoote Is this the kind of thing I could work on?

@tfoote
Copy link
Contributor

tfoote commented Dec 23, 2016

Yeah, We've tagged several issues "help wanted" or also "unclaimed" that you could look into.

There are many more, but we tried to pick out some good places for people to get involved.

@allenh1
Copy link
Contributor

allenh1 commented Dec 24, 2016

Well I'll start implementing this, then!

@allenh1
Copy link
Contributor

allenh1 commented Dec 26, 2016

For now, I'm putting these in the rcl.h header -- is this appropriate?

@allenh1
Copy link
Contributor

allenh1 commented Dec 26, 2016

Actually, after further investigation, I'm now thinking they should be implemented in several different header files (bool rcl_service_is_valid(const rcl_service_t * service) should be in service.h, and similar).

Alternatively, I suppose I could put them in a check.h header, but I'll implement them in the above fashion in the meantime.


First attempt: c5c6d7d

@wjwwood
Copy link
Member

wjwwood commented Dec 27, 2016

Putting them in the same header with the type you're checking seems appropriate to me.

@allenh1 allenh1 self-assigned this Jun 22, 2017
@allenh1 allenh1 added the in progress Actively being worked on (Kanban column) label Jun 22, 2017
@allenh1 allenh1 closed this as completed Jul 18, 2017
@allenh1 allenh1 removed the in progress Actively being worked on (Kanban column) label Jul 18, 2017
emersonknapp pushed a commit to aws-ros-dev/rcl that referenced this issue Jun 3, 2019
…os2#81)

* Move autoinits higher so allocator is set for error messages

It's only an issue for one of these, it's defensive for the others

* Add RCUTILS_WARN_UNUSED to logger functions with return values

* env var default documentation moved
ivanpauno pushed a commit that referenced this issue Jan 2, 2020
Control shared/static linking via BUILD_SHARED_LIBS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants