-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement rcl_x_is_valid methods #81
Comments
Thanks! |
@tfoote Is this the kind of thing I could work on? |
Yeah, We've tagged several issues "help wanted" or also "unclaimed" that you could look into. There are many more, but we tried to pick out some good places for people to get involved. |
Well I'll start implementing this, then! |
For now, I'm putting these in the |
Actually, after further investigation, I'm now thinking they should be implemented in several different header files ( Alternatively, I suppose I could put them in a First attempt: c5c6d7d |
Putting them in the same header with the type you're checking seems appropriate to me. |
…os2#81) * Move autoinits higher so allocator is set for error messages It's only an issue for one of these, it's defensive for the others * Add RCUTILS_WARN_UNUSED to logger functions with return values * env var default documentation moved
Control shared/static linking via BUILD_SHARED_LIBS
In order to track what was discussed in #78 I open this issue tracker.
@wjwwood suggested that in the future it might become necessary/useful to implement functions in the style
rcl_x_is_valid
.An example would be:
bool rcl_service_is_valid(rcl_service_t * service)
which would check if this service is valid. (Perhaps check if it's not null, check if it was initialized, and so on)The text was updated successfully, but these errors were encountered: