Several memory-related fixes for rcl_variant_t benchmarks #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `rcl_yaml_variant_fini` is already setting these values to `NULL`, so there isn't any reason to do that here. Signed-off-by: Scott K Logan <logans@cottsay.net>
Assuming the source entity isn't empty, the `rcl_yaml_variant_copy` is allocating memory during each iteration, and that memory needs to be deallocated. Signed-off-by: Scott K Logan <logans@cottsay.net>
Since the string is created with `rcutils_strdup`, it needs to be deallocated. Signed-off-by: Scott K Logan <logans@cottsay.net>
Unlike the `rcl_*` array types, the `rcutils_string_array_t` is initialized with `rcutils_string_array_init`, which sets the size. Signed-off-by: Scott K Logan <logans@cottsay.net>
|
ahcorde
approved these changes
Sep 28, 2020
delete-merged-branch
bot
deleted the
cottsay/benchmark/rcl_yaml_param_parser
branch
ahcorde
pushed a commit
that referenced
this pull request
Oct 5, 2020
* Remove a bunch of redundant nullptr assignments * Fix some memory leaks * Ensure source string is deallocated * Remove redundant array size assignment Signed-off-by: Scott K Logan <logans@cottsay.net>
ahcorde
pushed a commit
that referenced
this pull request
Oct 8, 2020
* Remove a bunch of redundant nullptr assignments * Fix some memory leaks * Ensure source string is deallocated * Remove redundant array size assignment Signed-off-by: Scott K Logan <logans@cottsay.net>
Barry-Xu-2018
pushed a commit
to Barry-Xu-2018/rcl
that referenced
this pull request
Oct 29, 2020
* Remove a bunch of redundant nullptr assignments * Fix some memory leaks * Ensure source string is deallocated * Remove redundant array size assignment Signed-off-by: Scott K Logan <logans@cottsay.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See each commit for justification.
Follow-up to #803 and #810