Make sure to always check return values. #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI:
|
jacobperron
reviewed
Oct 26, 2020
Pointed out by clang static analysis, we should always check these return values. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
force-pushed
the
clalancette/check-ret
branch
from
25ac87d
to
f8a75fa
Compare
|
CI:
|
jacobperron
reviewed
Oct 26, 2020
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
jacobperron
reviewed
Oct 26, 2020
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
One more CI to make sure this is good, then I'll merge:
|
|
All of the failed tests on Windows also failed in the nightly, so this looks good. Merging. |
ahcorde
pushed a commit
that referenced
this pull request
Oct 30, 2020
* Make sure to always check return values. Pointed out by clang static analysis, we should always check these return values. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
ahcorde
pushed a commit
that referenced
this pull request
Nov 2, 2020
* Make sure to always check return values. Pointed out by clang static analysis, we should always check these return values. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pointed out by clang static analysis, we should always
check these return values.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org