Implement rcl_clock_time_started #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methylDragon
force-pushed
the
time-valid
branch
2 times, most recently
from
b3c2184
to
d3a766b
Compare
methylDragon
requested review from
audrow,
ivanpauno and
wjwwood
as code owners
|
fujitatomoya
reviewed
Dec 5, 2022
There was a problem hiding this comment.
although this change itself looks good to me, i would suggest that the following procedure.
- revert Implement validity checks for time points #1018 only, and merge this revert commit in rolling.
- then apply
rcl_clock_time_started.
it is up to package maintainers, but highly recommended. each PR should have complete fix as less dependencies as possible.
Fair point! #1022 I've reconfigured this PR @fujitatomoya , the revert change is split off. I will merge on green CI |
methylDragon
force-pushed
the
time-valid
branch
2 times, most recently
from
3aaab01
to
78f1934
Compare
|
methylDragon
changed the title
fujitatomoya
approved these changes
Dec 5, 2022
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
time-valid
branch
from
7e31df0
to
51a0841
Compare
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 12, 2023
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 09d86e2)
methylDragon
added a commit
that referenced
this pull request
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #1018 and implements
rcl_clock_time_startedinstead, which checks if anrcl_clock_thas started (i.e., outputs a non-zero time when queried for current time.)This was from an internal discussion that concluded that checking for time validity on a time point doesn't make sense (std::chrono's time points have no concept of validity, a time point reflecting (0, 0) is valid.) Instead, what matters is if a clock has a time point or not.