Timer tests2 #165
Merged
Timer tests2 #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelarguedas
added
in progress
mikaelarguedas
force-pushed
the
timer_tests2
branch
from
d5c8a49
to
3fd20c0
Compare
mikaelarguedas
force-pushed
the
timer_tests2
branch
from
3fd20c0
to
4801ac7
Compare
mikaelarguedas
added
in review
|
This requires ros2/rcutils#73
I'll rerun a full CI for this branch once ros2/rcutils#73 is approved
|
|
ros2/rcutils#73 has been merged and I finally got a MacOS job through. |
wjwwood
approved these changes
Nov 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opening this for visibility, follow up of #163
We decided not to merge this yet to not add more windows flaky tests (all test relying on timing are flaky on Windows, possibly for performance reasons)