Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch rcl_lifecyle to ament_cmake_ros #186

Merged
merged 1 commit into from
Nov 20, 2017
Merged

Conversation

dhood
Copy link
Member

@dhood dhood commented Nov 20, 2017

connects to ros2/ros2#306
parallel of #93

I am interested in this to get access to ROS_PACKAGE_NAME for logging (see ros2/ament_cmake_ros#2 (comment))

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@dhood dhood added the in review Waiting for review (Kanban column) label Nov 20, 2017
@dhood dhood self-assigned this Nov 20, 2017
Copy link
Contributor

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikaelarguedas
Copy link
Member

This is also necessary to honor BUILD_SHARED_LIBS. (see ros2/ros2#306)

@dhood dhood merged commit 9f92f8f into master Nov 20, 2017
@dhood dhood deleted the rcl_lifecycle_ament_cmake_ros branch November 20, 2017 22:41
@dhood dhood removed the in review Waiting for review (Kanban column) label Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants