Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor init to not be global #336

Merged
merged 12 commits into from
Nov 30, 2018
Merged

refactor init to not be global #336

merged 12 commits into from
Nov 30, 2018

Commits on Nov 30, 2018

  1. refactor init to not be global 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    0af9c7b View commit details
    Browse the repository at this point in the history

  2. style changes 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    41c4cd5 View commit details
    Browse the repository at this point in the history

  3. refactor to hide use of C11 atomics in implementation 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    8c6219d View commit details
    Browse the repository at this point in the history

  4. fix new action tests 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    ccad5cf View commit details
    Browse the repository at this point in the history

  5. use alternative atomic init for Windows support

    @wjwwood
    wjwwood committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    8bd49ee View commit details
    Browse the repository at this point in the history

  6. updates after rebase 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    2ba4532 View commit details
    Browse the repository at this point in the history

  7. cleanup rmw_init_options before copying 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    2ab9f1a View commit details
    Browse the repository at this point in the history

  8. fix two bugs in new init code

    @wjwwood
    wjwwood committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    c7f6d25 View commit details
    Browse the repository at this point in the history

  9. relax validity checks in a few places to facilitate post shutdown cle… 

    …anup

Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    301ac15 View commit details
    Browse the repository at this point in the history

  10. fixing tests for new API behavior 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    23dbae5 View commit details
    Browse the repository at this point in the history

  11. to allocator -> to allocate

    @sloretz @wjwwood
    sloretz authored and wjwwood committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    53e9eef View commit details
    Browse the repository at this point in the history

  12. acutally call rmw_shutdown() and address review comments 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    2a5547a View commit details
    Browse the repository at this point in the history