Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial draft of the quality declaration #566

Closed
wants to merge 1 commit into from

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Feb 1, 2020

This is a quality declaration for rcl as described in the proposed REP-2004 (see ros-infrastructure/rep#218).

This declaration is aspirational, in that it states things which aren't currently true, but we plan to do soon so we can get it up to the highest level. I'll use it as a kind of TODO list for fixing up rcl, using line comments to keep track of progress of certain tasks.

This will most likely continue to evolve with the REP as well.

Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood added the enhancement New feature or request label Feb 1, 2020
@wjwwood wjwwood self-assigned this Feb 1, 2020

## Change Control Process

TODO fix link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


`rcl` uses `semver` according to the recommendation for ROS Core packages in the [ROS 2 Developer Guide](https://index.ros.org/doc/ros2/Contributing/Developer-Guide/#versioning), and is at or above a stable version, i.e. `>= 1.0.0`.

### API Stability Within a Released ROS Distribution

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are also part of the Versioning section of the developer guide. It's probably best to just link there and reduce duplication here.

- all pull request must pass CI on all [tier 1 platforms](https://www.ros.org/reps/rep-2000.html#support-tiers)
- all pull request must resolve related documentation changes before merging

## Documentation

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could link to the documentation guidelines common to all packages: https://index.ros.org/doc/ros2/Contributing/Developer-Guide/#documentation


### Linters and Static Analysis

TODO fix link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


`rcl` supports all of the tier 1 platforms as described in [REP-2000](https://www.ros.org/reps/rep-2000.html#support-tiers), and tests each change against all of them.

TODO make additional statements about non-tier 1 platforms?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just leave this out of the 1st version. Let's focus on what's needed to get a valid QD in.


### Coverage

TODO fix link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/rfc-rep-2004-package-quality-categories/13150/1

@wjwwood
Copy link
Member Author

wjwwood commented May 5, 2020

Close in favor of #639

@wjwwood wjwwood closed this May 5, 2020
@wjwwood wjwwood deleted the quality_declaration branch May 5, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants