Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat rmw_impl_id_check to call a testable function #725

Merged
merged 9 commits into from
Jul 27, 2020
Merged

Reformat rmw_impl_id_check to call a testable function #725

merged 9 commits into from
Jul 27, 2020

Commits on Jul 22, 2020

  1. Reformat rmw_impl_id_check to call a testable function 

    Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
    @Blast545
    Blast545 committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    01da6b7 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2020

  1. Reformat to expose the function in the public header 

    Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
    @Blast545
    Blast545 committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    a3115f9 View commit details
    Browse the repository at this point in the history

  2. Reformat style return result 

    Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
    @Blast545
    Blast545 committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    f3278d7 View commit details
    Browse the repository at this point in the history

  3. Expose macro names to be tested with the function checker 

    Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
    @Blast545
    Blast545 committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    4ea1537 View commit details
    Browse the repository at this point in the history

  4. Add test for failing cases of the function 

    Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
    @Blast545
    Blast545 committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    eb20455 View commit details
    Browse the repository at this point in the history

  5. Set error variable and log in the main caller 

    Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
    @Blast545
    Blast545 committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    9931857 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2020

  1. Use format string for logging 

    Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
    @Blast545
    Blast545 committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    c83239f View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2020

  1. Change name of checker function 

    Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
    @Blast545
    Blast545 committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    6177cce View commit details
    Browse the repository at this point in the history

  2. Reset rcl error to avoid overwrite 

    Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
    @Blast545
    Blast545 committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    334cbef View commit details
    Browse the repository at this point in the history