Fix test_rcl_lifecycle #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Brawner <brawner@gmail.com>
|
Standard build, testing
cyclonedds only
|
ivanpauno
approved these changes
Sep 3, 2020
delete-merged-branch
bot
deleted the
brawner/rcl_lifecycle-fix-test-rcl-lifecycle
branch
ahcorde
pushed a commit
that referenced
this pull request
Oct 8, 2020
Signed-off-by: Stephen Brawner <brawner@gmail.com>
ahcorde
pushed a commit
that referenced
this pull request
Oct 16, 2020
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test had a few issues after digging through it when investigating #787. The root cause of #787 was that the node was not being shutdown during the maybe_fail test, but there was also a few other issues with finalization that led to memory leaks. Lastly to match the style in other tests, I reversed
EXPECT/ASSERTso that the expected value was on the left-hand side.If the last style fix is undesired, I can switch that back.
Fixes #787.
Signed-off-by: Stephen Brawner brawner@gmail.com