Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service introspection #997

Merged
merged 6 commits into from
Feb 28, 2023
Merged

Service introspection #997

merged 6 commits into from
Feb 28, 2023

Commits on Feb 24, 2023

  1. Add in the APIs to enable service introspection.

    This PR adds in the rcl implementation of service introspection.
    In particular, what it adds in are the implementations of enabling
    and disabling service introspection, as well as creating the publisher
    when the introspection is enabled.
    
    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    ihasdapie authored and clalancette committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    cbc03e8 View commit details
    Browse the repository at this point in the history
  2. Implement service introspection.

    The idea here is that by default, clients and services are
    created just like they were before.  However, we add an
    additional API where the user can choose to configure
    service introspection, either to turn it OFF, send out
    METADATA, or send out CONTENTS (and METADATA).
    
    There are 4 different events that can get sent out if
    introspection is configured for METADATA or CONTENTS;
    REQUEST_SENT (from the client), REQUEST_RECEIVED (from
    the service), RESPONSE_SENT (from the service), or
    RESPONSE_RECEIVED (from the client).  For each of these,
    a separate message is sent out a topic called
    <service_name>_service_event , so an outside observer can
    listen.
    
    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    clalancette committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    296e518 View commit details
    Browse the repository at this point in the history
  3. Minor bug fix when shutting down.

    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    clalancette committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    f4a6263 View commit details
    Browse the repository at this point in the history
  4. Fix tests to work with Connext.

    Along the way, I noticed quite a few potential bugs, so
    this ends up mostly being a rewrite of the tests.  With
    this in place, tests pass on all RMWs.
    
    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    clalancette committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    fe72a35 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2023

  1. Scope patch_to_fail.

    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    clalancette committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    8b60900 View commit details
    Browse the repository at this point in the history
  2. Fix for warning on Windows.

    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    clalancette committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    6fcbd03 View commit details
    Browse the repository at this point in the history