Add quality declarations for each package except test_msgs #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brawner
force-pushed
the
quality_declaration
branch
2 times, most recently
from
d61afca
to
1ce14b5
Compare
brawner
force-pushed
the
quality_declaration
branch
from
1ce14b5
to
5f4ada0
Compare
|
This PR was updated to reflect the current status of each package (4). |
brawner
force-pushed
the
quality_declaration
branch
from
5f4ada0
to
b2d5ca1
Compare
|
New commit: b2d5ca1 |
Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
force-pushed
the
quality_declaration
branch
2 times, most recently
from
ea1fb1d
to
090b103
Compare
|
Ok, I addressed the feedback and applied it to the rest of the quality declarations. This PR has become a bit tricky to review since it depends on #91 and it includes two commits itself. I can squash the two commits here if that would make it easier to review. Otherwise you can see an overall comparison of just this PR here: |
ahcorde
requested changes
Apr 27, 2020
ahcorde
reviewed
Apr 27, 2020
Signed-off-by: Stephen Brawner <brawner@gmail.com> Switch QDs to their QL current-level (4) Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
force-pushed
the
quality_declaration
branch
from
fd468a1
to
4b11b70
Compare
ahcorde
requested changes
Apr 29, 2020
brawner
force-pushed
the
quality_declaration
branch
from
d9913f7
to
145bb78
Compare
brawner
commented
Apr 29, 2020
ahcorde
approved these changes
Apr 30, 2020
|
Verifying all ros2 packages build, and I didn't break anything. |
|
CMake warning is unrelated to this documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a QUALITY_DECLARATION.md for each package that describes aspirationally how it meets quality level 1. Aside from the dependent PRs (#89, #90, #91), this repo does not need further modifications to achieve QL 1 after an API review.
There is one unresolved question regarding the message and service file definitions. It has not been historic practice to include a copyright statement in a message or service definition, which may lead to questions about who retains the copyright for such files considering many were copied over from non-copyrighted message/service file definitions in ROS 1. The QD rep generally requires copyright statements in source files, so this package would be atypical.
Furthermore, since none of the files in these QL 1 packages have copyrighted files, it's unclear what is even under the Apache 2 license and what purpose that license serves for this package.
New commit: b2d5ca1