Export spdlog dependency for rcl_logging_spdlog #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexisTM
changed the title
Signed-off-by: PAA1TI <PAA1TI@bosch.com>
AlexisTM
force-pushed
the
feature/fix_spdlog_dependency
branch
from
7a6b445
to
bfdbad2
Compare
|
Could you please retarget this PR to the |
|
Actually, #89 is a superset of this one, so I'm going to close this in favor of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
OS: Apertis 2022 (Debian bullseye based)
ROS Version: Galactic
rcl_logging version: 2.1.4
GCC: aarch64-linux-gnu-g++ (Apertis 10.2.1-6+apertis2+apertispro0bv2022dev3b1) 10.2.1 20210110
Arch: aarch64
Description
When cross-building for our project,
rclcpp_componentsand otherrclcpppackages fails to link to spdlog, saying:spdlog.so.1 not foundwhile available in the workspace's lib folder (which is in theCMAKE_FIND_ROOT_PATH).Explicitly adding spdlog as a dependency of
rcl_logging_spdlogfixes the issue.ament_export_dependencies(rcl_logging_interface spdlog)Note: The build works fine without this when building natively on the host (x86_64).
Note2: This fix is based on the galactic branch