Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rolling] updated ros-tooling versions #289

Merged
merged 4 commits into from
May 30, 2022

Conversation

JanStaschulat
Copy link
Contributor

No description provided.

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
@JanStaschulat JanStaschulat changed the title updated ros-tooling versions [rolling] updated ros-tooling versions May 6, 2022
@JanStaschulat
Copy link
Contributor Author

@mergify backport galactic foxy

@mergify
Copy link
Contributor

mergify bot commented May 6, 2022

backport galactic foxy

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
@JanStaschulat
Copy link
Contributor Author

JanStaschulat commented May 6, 2022

There seems to be a upstream issue with ros-rqt packages:

The following packages have unmet dependencies:
   ros-rolling-rqt-common-plugins : Depends: ros-rolling-rqt-top but it is not installable
  E: Unable to correct problems, you have held broken packages.
Error: The process '/usr/bin/sudo' failed with exit code 100

https://github.com/ros2/rclc/runs/6320476333?check_suite_focus=true

I am waiting a few days to check if this get resolves.

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
@codecov-commenter
Copy link

Codecov Report

Merging #289 (5bd63e3) into master (b73a773) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
- Coverage   69.20%   69.13%   -0.08%     
==========================================
  Files          16       16              
  Lines        2715     2715              
  Branches      765      765              
==========================================
- Hits         1879     1877       -2     
- Misses        450      451       +1     
- Partials      386      387       +1     
Impacted Files Coverage Δ
rclc/src/rclc/action_goal_handle.c 59.87% <0.00%> (-1.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b73a773...5bd63e3. Read the comment docs.

@JanStaschulat JanStaschulat merged commit eac6a8d into master May 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the feature/update-ros-tooling-versions branch May 30, 2022 11:00
@mergify
Copy link
Contributor

mergify bot commented May 30, 2022

backport galactic foxy

❌ No backport have been created

The new Mergify permissions must be accepted to create pull request with .github/workflows changes.
You can accept them at https://dashboard.mergify.com/

@JanStaschulat
Copy link
Contributor Author

@mergify backport humble galactic foxy

mergify bot pushed a commit that referenced this pull request Jun 2, 2022
* updated ros-tooling versions

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* reverted back to setup-ros@0.3.0

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* ros-tooling/setup-ros@0.3.1

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* updated ros-tooling/setup-ros@0.3.3

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
(cherry picked from commit eac6a8d)

# Conflicts:
#	.github/workflows/ci.yml
mergify bot pushed a commit that referenced this pull request Jun 2, 2022
* updated ros-tooling versions

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* reverted back to setup-ros@0.3.0

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* ros-tooling/setup-ros@0.3.1

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* updated ros-tooling/setup-ros@0.3.3

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
(cherry picked from commit eac6a8d)

# Conflicts:
#	.github/workflows/ci.yml
mergify bot pushed a commit that referenced this pull request Jun 2, 2022
* updated ros-tooling versions

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* reverted back to setup-ros@0.3.0

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* ros-tooling/setup-ros@0.3.1

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* updated ros-tooling/setup-ros@0.3.3

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
(cherry picked from commit eac6a8d)

# Conflicts:
#	.github/workflows/ci.yml
@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2022

backport humble galactic foxy

✅ Backports have been created

JanStaschulat added a commit that referenced this pull request Jun 2, 2022
* [rolling] updated ros-tooling versions (#289)

* updated ros-tooling versions

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* reverted back to setup-ros@0.3.0

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* ros-tooling/setup-ros@0.3.1

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* updated ros-tooling/setup-ros@0.3.3

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
(cherry picked from commit eac6a8d)

# Conflicts:
#	.github/workflows/ci.yml

* resolved merge conflict

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com>
JanStaschulat added a commit that referenced this pull request Jun 2, 2022
* [rolling] updated ros-tooling versions (#289)

* updated ros-tooling versions

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* reverted back to setup-ros@0.3.0

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* ros-tooling/setup-ros@0.3.1

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* updated ros-tooling/setup-ros@0.3.3

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
(cherry picked from commit eac6a8d)

# Conflicts:
#	.github/workflows/ci.yml

* resolved merge conflict

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com>
JanStaschulat added a commit that referenced this pull request Jun 2, 2022
* [rolling] updated ros-tooling versions (#289)

* updated ros-tooling versions

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* reverted back to setup-ros@0.3.0

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* ros-tooling/setup-ros@0.3.1

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

* updated ros-tooling/setup-ros@0.3.3

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
(cherry picked from commit eac6a8d)

# Conflicts:
#	.github/workflows/ci.yml

* resolved merge conflict

Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>

Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants