updated rclc_examples #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JanStaschulat
commented
Feb 7, 2023
•
JanStaschulat
commented
- renamed example_executor_convenience.c to example_executor.c (this should be the typical use case)
- renamed example_executor.c to example_executor_only_rcl.c (depricated, was only used to show that the executor can be used with RCL API alone.
- changed rclc_executor_spin_some with for-loop to rclc_executor_spin() (this should be the typical use case)
- updated README
- added a note about the XRCE-DDS middleware configuration of number of publishers/subscribers etc.
- corrected link for example_short_timer_long_callback demo
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
|
@mergify backport foxy humble |
✅ Backports have been created
|
pablogs9
approved these changes
Feb 7, 2023
mergify bot
pushed a commit
that referenced
this pull request
Feb 7, 2023
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> (cherry picked from commit e63b644) # Conflicts: # rclc_examples/README.md
mergify bot
pushed a commit
that referenced
this pull request
Feb 7, 2023
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> (cherry picked from commit e63b644)
JanStaschulat
added a commit
that referenced
this pull request
Feb 8, 2023
JanStaschulat
added a commit
that referenced
this pull request
Feb 8, 2023
* updated documentation (#332) Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> (cherry picked from commit e63b644) # Conflicts: # rclc_examples/README.md * resolved merge conflict Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> --------- Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.