Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-Authored-By: wjwwood <william+github@osrfoundation.org>
  • Loading branch information
jacobperron and wjwwood committed Dec 12, 2018
1 parent e73e040 commit 74d018d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions rclcpp/src/rclcpp/signal_handler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ SignalHandler::install()
}
try {
setup_wait_for_signal();
signal_received_.exchange(false);
signal_received_.store(false);

SignalHandler::signal_handler_type signal_handler_argument;
#if defined(RCLCPP_HAS_SIGACTION)
Expand All @@ -85,7 +85,7 @@ SignalHandler::install()

signal_handler_thread_ = std::thread(&SignalHandler::deferred_signal_handler, this);
} catch (...) {
installed_.exchange(false);
installed_.store(false);
throw;
}
RCLCPP_DEBUG(get_logger(), "signal handler installed");
Expand Down Expand Up @@ -186,7 +186,7 @@ SignalHandler::set_signal_handler(
void
SignalHandler::signal_handler_common()
{
SignalHandler::signal_received_.exchange(true);
SignalHandler::signal_received_.store(true);
RCLCPP_DEBUG(
get_logger(),
"signal_handler(): SIGINT received, notifying deferred signal handler");
Expand Down

0 comments on commit 74d018d

Please sign in to comment.