changes

Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
ros2 · Jul 16, 2019 · d7ef517 · d7ef517
1 parent bb4ca14
commit d7ef517
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 44 deletions.
diff --git a/rclcpp_components/cmake/rclcpp_components_add_library_with_nodes.cmake b/rclcpp_components/cmake/rclcpp_components_add_library_with_nodes.cmake
diff --git a/rclcpp_components/cmake/rclcpp_components_register_node.cmake b/rclcpp_components/cmake/rclcpp_components_register_node.cmake
@@ -13,7 +13,7 @@
 # limitations under the License.
 #
 # usage: rclcpp_components_register_node(
-#              <target> <component> <node>)
+#              <target> PLUGIN <component> EXECUTABLE <node>)
 #
 # Register an rclcpp component with the ament
 # resource index and create an executable.

diff --git a/rclcpp_components/src/node_main.cpp.in b/rclcpp_components/src/node_main.cpp.in
@@ -41,7 +41,7 @@ int main(int argc, char * argv[])
     "",
   };
   std::string className = "rclcpp_components::NodeFactoryTemplate<@CLASS_NAME@>";
-  for (auto library : libraries) {
+  for (const auto & library : libraries) {
     RCLCPP_DEBUG(logger, "Loading library %s", library.c_str());
     auto loader = new class_loader::ClassLoader(library);
     auto classes = loader->getAvailableClasses<rclcpp_components::NodeFactory>();
@@ -65,9 +65,6 @@ int main(int argc, char * argv[])
     exec.remove_node(wrapper.get_node_base_interface());
   }
   node_wrappers.clear();
-
   rclcpp::shutdown();
-
-
   return 0;
 }