Skip unsupported test cases for connextdds

Signed-off-by: Barry Xu <barry.xu@sony.com>

rclcpp/test/rclcpp/test_qos_event.cpp

@@ -314,6 +314,11 @@ TEST_F(TestQosEvent, add_to_wait_set) {
 
 TEST_F(TestQosEvent, test_on_new_event_callback)
 {
+  // rmw_connextdds doesn't support rmw_event_set_callback() interface
+  if (std::string(rmw_get_implementation_identifier()).find("rmw_connextdds") == 0) {
+    GTEST_SKIP();
+  }
+
   auto offered_deadline = rclcpp::Duration(std::chrono::milliseconds(1));
   auto requested_deadline = rclcpp::Duration(std::chrono::milliseconds(2));
 
@@ -355,6 +360,11 @@ TEST_F(TestQosEvent, test_on_new_event_callback)
 
 TEST_F(TestQosEvent, test_invalid_on_new_event_callback)
 {
+  // rmw_connextdds doesn't support rmw_event_set_callback() interface
+  if (std::string(rmw_get_implementation_identifier()).find("rmw_connextdds") == 0) {
+    GTEST_SKIP();
+  }
+
   auto pub = node->create_publisher<test_msgs::msg::Empty>(topic_name, 10);
   auto sub = node->create_subscription<test_msgs::msg::Empty>(topic_name, 10, message_callback);
   auto dummy_cb = [](size_t count_events) {(void)count_events;};
@@ -377,20 +387,17 @@ TEST_F(TestQosEvent, test_invalid_on_new_event_callback)
   EXPECT_NO_THROW(
     pub->clear_on_new_qos_event_callback(RCL_PUBLISHER_OFFERED_INCOMPATIBLE_QOS));
 
-  // rmw_connextdds doesn't support rmw_event_set_callback() interface
-  if (std::string(rmw_get_implementation_identifier()).find("rmw_connextdds") != 0) {
-    EXPECT_NO_THROW(
-      pub->set_on_new_qos_event_callback(dummy_cb, RCL_PUBLISHER_MATCHED));
+  EXPECT_NO_THROW(
+    pub->set_on_new_qos_event_callback(dummy_cb, RCL_PUBLISHER_MATCHED));
 
-    EXPECT_NO_THROW(
-      pub->clear_on_new_qos_event_callback(RCL_PUBLISHER_MATCHED));
+  EXPECT_NO_THROW(
+    pub->clear_on_new_qos_event_callback(RCL_PUBLISHER_MATCHED));
 
-    EXPECT_NO_THROW(
-      pub->set_on_new_qos_event_callback(dummy_cb, RCL_PUBLISHER_UNMATCHED));
+  EXPECT_NO_THROW(
+    pub->set_on_new_qos_event_callback(dummy_cb, RCL_PUBLISHER_UNMATCHED));
 
-    EXPECT_NO_THROW(
-      pub->clear_on_new_qos_event_callback(RCL_PUBLISHER_UNMATCHED));
-  }
+  EXPECT_NO_THROW(
+    pub->clear_on_new_qos_event_callback(RCL_PUBLISHER_UNMATCHED));
 
   EXPECT_NO_THROW(
     sub->set_on_new_qos_event_callback(dummy_cb, RCL_SUBSCRIPTION_REQUESTED_DEADLINE_MISSED));
@@ -410,20 +417,17 @@ TEST_F(TestQosEvent, test_invalid_on_new_event_callback)
   EXPECT_NO_THROW(
     sub->clear_on_new_qos_event_callback(RCL_SUBSCRIPTION_REQUESTED_INCOMPATIBLE_QOS));
 
-  // rmw_connextdds doesn't support rmw_event_set_callback() interface
-  if (std::string(rmw_get_implementation_identifier()).find("rmw_connextdds") != 0) {
-    EXPECT_NO_THROW(
-      sub->set_on_new_qos_event_callback(dummy_cb, RCL_SUBSCRIPTION_MATCHED));
+  EXPECT_NO_THROW(
+    sub->set_on_new_qos_event_callback(dummy_cb, RCL_SUBSCRIPTION_MATCHED));
 
-    EXPECT_NO_THROW(
-      sub->clear_on_new_qos_event_callback(RCL_SUBSCRIPTION_MATCHED));
+  EXPECT_NO_THROW(
+    sub->clear_on_new_qos_event_callback(RCL_SUBSCRIPTION_MATCHED));
 
-    EXPECT_NO_THROW(
-      sub->set_on_new_qos_event_callback(dummy_cb, RCL_SUBSCRIPTION_UNMATCHED));
+  EXPECT_NO_THROW(
+    sub->set_on_new_qos_event_callback(dummy_cb, RCL_SUBSCRIPTION_UNMATCHED));
 
-    EXPECT_NO_THROW(
-      sub->clear_on_new_qos_event_callback(RCL_SUBSCRIPTION_UNMATCHED));
-  }
+  EXPECT_NO_THROW(
+    sub->clear_on_new_qos_event_callback(RCL_SUBSCRIPTION_UNMATCHED));
 
   std::function<void(size_t)> invalid_cb;