Add rclcpp_action action_server benchmarks #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Brawner <brawner@gmail.com>
|
Cancel goal benchmark is failing currently for some reason, so I need to debug that, but I thought it would be helpful to get some initial feedback on this PR. |
ahcorde
approved these changes
Nov 2, 2020
Signed-off-by: Stephen Brawner <brawner@gmail.com>
|
I think I was able to address the above bug
|
Signed-off-by: Stephen Brawner <brawner@gmail.com>
|
Addressed a couple of issues that only Windows seemed to care about.
|
|
Interestingly, MSVC doesn't seem to handle constexpr variables appropriately with respect to lambda captures. Anyway, Clang and MSVC disagree about the resolution. I hope the most recent commit is something they can agree on
|
Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
force-pushed
the
brawner/rclcpp_action-benchmark-service
branch
from
5d1ae40
to
0e72aa0
Compare
|
delete-merged-branch
bot
deleted the
brawner/rclcpp_action-benchmark-service
branch
brawner
added a commit
that referenced
this pull request
Nov 5, 2020
* Add rclcpp_action action_server benchmarks Signed-off-by: Stephen Brawner <brawner@gmail.com> * Address cancel bug Signed-off-by: Stephen Brawner <brawner@gmail.com> * Fix errors Signed-off-by: Stephen Brawner <brawner@gmail.com> * Fix clang error Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
added a commit
that referenced
this pull request
Nov 6, 2020
* Add rclcpp_action action_server benchmarks Signed-off-by: Stephen Brawner <brawner@gmail.com> * Address cancel bug Signed-off-by: Stephen Brawner <brawner@gmail.com> * Fix errors Signed-off-by: Stephen Brawner <brawner@gmail.com> * Fix clang error Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
added a commit
that referenced
this pull request
Nov 7, 2020
* Add rclcpp_action action_server benchmarks Signed-off-by: Stephen Brawner <brawner@gmail.com> * Address cancel bug Signed-off-by: Stephen Brawner <brawner@gmail.com> * Fix errors Signed-off-by: Stephen Brawner <brawner@gmail.com> * Fix clang error Signed-off-by: Stephen Brawner <brawner@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds benchmarks for rclcpp_action's action server.
Building with benchmarks and testing
--packages-select rclcpp_actionSigned-off-by: Stephen Brawner brawner@gmail.com