Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmarks for components #1476

Merged
merged 3 commits into from
Nov 25, 2020
Merged

Add benchmarks for components #1476

merged 3 commits into from
Nov 25, 2020

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Nov 25, 2020 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@cottsay
Add benchmarks for components
34fc9bc 
Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay added in review Waiting for review (Kanban column) tests Failing or missing tests labels Nov 25, 2020
@cottsay cottsay requested a review from brawner November 25, 2020 00:59
@cottsay cottsay self-assigned this Nov 25, 2020
@cottsay
fixup! Add benchmarks for components
5e725db 
Signed-off-by: Scott K Logan <logans@cottsay.net>
brawner
brawner approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@brawner brawner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments, but with that this should be good to go.

rclcpp_components/test/benchmark/benchmark_components.cpp Outdated Show resolved Hide resolved
rclcpp_components/test/benchmark/benchmark_components.cpp Show resolved Hide resolved
rclcpp_components/test/benchmark/benchmark_components.cpp Show resolved Hide resolved
@cottsay
Address PR feedback
42f5919 
Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay
Copy link
Member Author

cottsay commented Nov 25, 2020

build.ros2.org is in maintenance right now, so that PR job probably won't run for a while. The results from ci.ros2.org came back OK, so I'm going to go ahead and merge this.

@cottsay cottsay merged commit 08963df into master Nov 25, 2020
@delete-merged-branch delete-merged-branch bot deleted the cottsay/component_benchmark branch November 25, 2020 22:52
@cottsay cottsay mentioned this pull request Nov 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brawner brawner brawner approved these changes

Assignees

@cottsay cottsay

Labels
in review Waiting for review (Kanban column) tests Failing or missing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cottsay @brawner