Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create load_parameters and delete_parameters methods on rclcpp::[A]syncParametersClient #1586

Closed
BriceRenaudeau opened this issue Mar 19, 2021 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@BriceRenaudeau
Copy link
Contributor

Feature request

Feature description

It would be great to add these two methods to rclcpp::[A]syncParametersClient:

  1. load_parameters to do the same as ros2 param load [node] [yaml_file]
  2. delete_parameters to do the same as ros2 param delete [node] [parameters]

Implementation considerations

Right now, I am using a system call to execute these two commands.

@BriceRenaudeau
Copy link
Contributor Author

To delete a parameter one can use :

// without value, it sets the parameter to NOT_SET, behave like delete
auto set_results = parameter_client->set_parameters({rclcpp::Parameter(param)});

@wjwwood
Copy link
Member

wjwwood commented Mar 19, 2021

Makes sense to me, we only have them implemented in rclpy (or maybe just in ros2param). Bonus points for considering if working it into rcl so rclpy and rclcpp can share the same implementation of these two functions makes sense.

@wjwwood wjwwood added help wanted Extra attention is needed enhancement New feature or request labels Mar 19, 2021
@BriceRenaudeau
Copy link
Contributor Author

Linked issue #1029

@sloretz
Copy link
Contributor

sloretz commented Jun 4, 2021

Closing as this appears to have been resolved by #1596

@sloretz sloretz closed this as completed Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants