Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix virtual dispatch issues identified by clang-tidy #1816

Merged
merged 6 commits into from
Jun 22, 2022
Merged

fix virtual dispatch issues identified by clang-tidy #1816

merged 6 commits into from
Jun 22, 2022

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Nov 4, 2021 •
edited
Loading

fixes space-ros/space-ros#8

I might come back and try to de-duplicate some of the code, but I couldn't find a nice solution yet.

@alsora
Copy link
Collaborator

alsora commented Nov 11, 2021

The changes look good to me.
However, it seems like the link that describes the problem is dead (or I can't access to see it)

@wjwwood
Copy link
Member Author

wjwwood commented Mar 21, 2022

We moved the issue to a new place, which should be accessible. space-ros/space-ros#8

@wjwwood wjwwood force-pushed the clang_tidy_fix_virtual_dispatch_issues branch from 53ed68b to 4369a9f Compare April 6, 2022 00:53
@wjwwood wjwwood requested a review from ivanpauno April 6, 2022 18:25
@wjwwood
Copy link
Member Author

wjwwood commented Apr 6, 2022

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

ivanpauno
ivanpauno reviewed Apr 7, 2022
View reviewed changes
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that doesn't seem directly related to the PR.
I have left some comments in those.
If they aren't related, maybe we can open new PRs for them (?).

Otherwise LGTM!

rclcpp/include/rclcpp/context.hpp Show resolved Hide resolved
rclcpp/include/rclcpp/context.hpp Show resolved Hide resolved
rclcpp/include/rclcpp/node_interfaces/node_base.hpp Show resolved Hide resolved
rclcpp/include/rclcpp/node_interfaces/node_parameters.hpp Show resolved Hide resolved
@wjwwood
Copy link
Member Author

wjwwood commented May 10, 2022

I think I addressed all your comments with just replies, but please have another look when you can.

@wjwwood
Copy link
Member Author

wjwwood commented May 10, 2022 •
edited
Loading

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status (updated with new job due to CI issue)

fujitatomoya
fujitatomoya approved these changes May 10, 2022
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wjwwood wjwwood force-pushed the clang_tidy_fix_virtual_dispatch_issues branch from ac424bc to b4e8de3 Compare May 13, 2022 02:07
@wjwwood
Copy link
Member Author

wjwwood commented May 13, 2022 •
edited
Loading

New CI after rebase (I think the Windows failure was fixed on master?):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status (edit: SSL error)

@wjwwood
Copy link
Member Author

wjwwood commented Jun 2, 2022

I still need to fix a new compiler warning on Windows here.

@wjwwood wjwwood force-pushed the clang_tidy_fix_virtual_dispatch_issues branch from b4e8de3 to 480d527 Compare June 13, 2022 21:38
@wjwwood
fix virtual dispatch issues identified by clang-tidy
37466de 
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood
fix up to reduce code duplication
01cafcc 
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood
uncrustify
d0f4a2d 
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood
avoid returning temporaries
a84ad74 
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood force-pushed the clang_tidy_fix_virtual_dispatch_issues branch from 0906a3a to a84ad74 Compare June 15, 2022 00:19
@wjwwood
Copy link
Member Author

wjwwood commented Jun 15, 2022

I think I fixed the compiler warnings on Windows (finally), CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@wjwwood
uncrustify
fab5469 
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood
Copy link
Member Author

wjwwood commented Jun 16, 2022

Uncrustify, new CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@wjwwood
Copy link
Member Author

wjwwood commented Jun 20, 2022

The Windows test failure is unrelated and flaky.

@wjwwood
add docs about overriding methods used in constructors
d4aa970 
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood
Copy link
Member Author

wjwwood commented Jun 22, 2022

The test timeout in Rpr is unrelated.

@wjwwood wjwwood merged commit dbded5c into master Jun 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the clang_tidy_fix_virtual_dispatch_issues branch June 22, 2022 01:59
nuclearsandwich added a commit to nuclearsandwich/rclcpp that referenced this pull request Jul 18, 2022
@nuclearsandwich
Revert "fix virtual dispatch issues identified by clang-tidy (ros2#1816…
a9d9c13 
…)"

This reverts commit dbded5c.
I'm just doing this to test a build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@wjwwood wjwwood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clang-tidy: Virtual dispatch
4 participants
@wjwwood @alsora @ivanpauno @fujitatomoya